test(core): close reranker phase-1 coverage gaps - #1232
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 + the small-fixes section of #1231 (reranker test plan, post-#1143 audit).
Commits
stale
Xenova/ms-marco-MiniLM-L-6-v2default now references the sharedDEFAULT_FASTEMBED_RERANK_MODELconstant; newreranker_timeoutconfig field(default 30.0,
gt=0) threads through the factory to the LiteLLM provider and joins thesingleton cache key (litellm only, so fastembed keys are unaffected). Documented in the
semantic-search guide; FastEmbed ignores it by design.
searchadapterno longer collapses rerank 503s into "Internal search error": it detects
search_notes'service-unavailable response and returns a distinguishable "Search temporarily
unavailable, retry shortly" payload so OpenAI clients can retry.
rerank_search_repositoryfixture runs the identical scenarios againstSQLiteSearchRepository and PostgresSearchRepository (37 pass on each backend, zero
skips), so hybrid/vector rerank ordering is guarded in the main unit shards.
permalink searches never invoke it and match baseline ranking.
create_search_repositoryinjects the provider into both backends;repository
__init__self-resolution only fires whensemantic_search_enabled.reranker_max_document_charsverified end-to-end from config to the document text theprovider receives.
Verification
BASIC_MEMORY_TEST_POSTGRES=1pipeline run: 37 passed, no skips (testcontainers).just typecheck,just lint: clean.Ticks the Phase 1 and small-fixes checkboxes on #1231; Phases 2-4 (real-model smoke, live
provider harness, quality regression, operational drills) remain tracked there.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CPdSXDbYyhyZ1TwgFnpEv8